Add npm install instructions to readme #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add install instructions.
AlbertMarashi
suggested changes
May 18, 2020
| ``` | ||
| npm install --save svelte svelte-loader | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Suggested change
| Svelte-loader requires svelte as a peer dependency, if you haven't already, run `npm install svelte` |
| ## Install | ||
|
|
||
| ``` | ||
| npm install --save svelte svelte-loader |
There was a problem hiding this comment.
Suggested change
| npm install --save svelte svelte-loader | |
| npm install --save svelte-loader |
|
I feel like this is more clear, as many people may already have svelte installed |
|
I think it's okay as is. It's more concise and won't install a duplicate version |
syvb
added a commit
to syvb/svelte-loader
that referenced
this pull request
Sep 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Add install instructions.
Why? I wasn't paying attention when I installed the loader, and didn't realise
sveltewas a peer dependency. This should make it more clear ✌️