Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<noscript> handling #1108

Closed
Rich-Harris opened this issue Jan 15, 2018 · 1 comment · Fixed by #1160
Closed

<noscript> handling #1108

Rich-Harris opened this issue Jan 15, 2018 · 1 comment · Fixed by #1160
Labels
feature request

Comments

@Rich-Harris
Copy link
Member

Via sveltejs/sapper#76. It probably makes sense just to ignore anything inside a <noscript> that's part of the template (except in SSR mode), since the fact that the component is rendering is proof that <noscript> doesn't apply.
@Rich-Harris Rich-Harris mentioned this issue Jan 15, 2018
Closed
@arxpoetica
Copy link
Member

Agreed, as long as long as we document that <noscript>, if needed, should be placed outside the context of any given component.

Conduitry added a commit that referenced this issue Feb 8, 2018
@Conduitry
remove <noscript> elements in DOM mode (#1108)
50d95e1
@Conduitry Conduitry mentioned this issue Feb 8, 2018
Merged
Rich-Harris added a commit that referenced this issue Feb 9, 2018
@Rich-Harris
Merge pull request #1160 from sveltejs/gh-1108
a33dfe5 
remove <noscript> elements in DOM mode (#1108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove <noscript> elements in DOM mode (#1108) sveltejs/svelte
2 participants
@arxpoetica @Rich-Harris