Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[svelte 5]: stopPropagation works differently than v4 (non runes mode) #11365

Closed
rob-balfre opened this issue Apr 28, 2024 · 2 comments · Fixed by #11369
Closed

[svelte 5]: stopPropagation works differently than v4 (non runes mode) #11365

rob-balfre opened this issue Apr 28, 2024 · 2 comments · Fixed by #11369
Assignees
Milestone

Comments

@rob-balfre
Copy link
Contributor

Describe the bug

stopPropagation no longer getting caught by container elements

Blocking people using svelte-select with v5
rob-balfre/svelte-select#680

Reproduction

v5 REPL:
https://svelte-5-preview.vercel.app/#H4sIAAAAAAAAE2WQwWrDMAyGX8Xo0hbKOnpM08BgD7D7vIMbK5mZIxlbDi1p3n04GRTWk_D_S78-a4LOeUxQfU5AZkCo4C0E2IPcQnmkEb0g7CFxjm1R6tRGF6TRpKXL1IpjUt-GrMcctib2OzUVT0vLlNjji-d-0U9FLNasqT48Yqi2blRMVWBHgjGH87TdqXPziN1wFoyb3bysfeq_h4gjkrxjZ7KXexIOH5GD6c2CF9njWQMxoYZmpasvWYSp5LTetT__h54ZHNHKsPSrAevDmrFCHawbm_KztWqqk9w8LmYB_rvKhaPFWKljuKrE3ll18RlPqxmMtY76Sh1fw_X0uNUSBHsY2LrOoYVKYsb5a_4F8lsCo8ABAAA=

v4 REPL:
https://svelte.dev/repl/d8eb12c5d909474aac79f5bdba783d0c?version=4.2.15

Logs

No response

System Info

System:
    OS: macOS 14.4.1
    CPU: (8) arm64 Apple M1
    Memory: 122.20 MB / 8.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.1 - ~/.nvm/versions/node/v20.11.1/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.1/bin/npm
    pnpm: 9.0.6 - ~/pnpm/pnpm
    bun: 1.0.0 - ~/.bun/bin/bun
  Browsers:
    Chrome: 124.0.6367.91
    Firefox Nightly: 124.0a1
    Safari: 17.4.1
    Safari Technology Preview: 17.4

Severity

blocking an upgrade

@nuts-n-bits
Copy link

There is a new syntax with svelte 5 which does these things: https://svelte-5-preview.vercel.app/docs/event-handlers#event-modifiers

It doesn't mean this issue is invalid, but it's good to know if you don't already.

@rob-balfre
Copy link
Contributor Author

@dummdidumm many many thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants