-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not accepting PayPal input image statement with an alt message. #3331
Labels
Comments
This is reproducible in the REPL. <input type="image" alt="PayPal: A safe way to make donations." src="https://www.paypalobjects.com/en_US/i/btn/btn_donateCC_LG.gif" border="0" name="submit"> Svelte returns an incorrect warning about this element needing |
svelte/src/compiler/compile/nodes/Element.ts Line 453 in abcdc74
We're not actually checking whether one of the expected attributes is present before calling the function that emits the warning. |
Conduitry
added a commit
to Conduitry/sveltejs_svelte
that referenced
this issue
Aug 2, 2019
Rich-Harris
added a commit
that referenced
this issue
Aug 3, 2019
fix erroneous a11y warning with input type='image'
This is fixed in 3.6.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I have a component that uses an input type image and it has an alt message also. But the svelte compiler is constantly warning that it needs an alt message.
Logs
To Reproduce
Have a component with the the html for a PayPal donate button. It will always generate the error when you compile. But, since it's a warning, I still get the processed files okay.
Occasionally, this won't be possible, and that's fine – we still appreciate you raising the issue. But please understand that Svelte is run by unpaid volunteers in their free time, and issues that follow these instructions will get fixed faster.
Expected behavior
It should compile without errors since the input image element has an alt message.
Information about your Svelte project:
NW.js version 40
Macos Mogave
3.6.8
Rollup 1.17
Severity
How severe an issue is this bug to you? Is this annoying, blocking some users, blocking an upgrade or blocking your usage of Svelte entirely?
It's just very annoying. I hate to have error messages/warnings.
Note: the more honest and specific you are here the more we will take you seriously.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: