Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

destroy not a valid callee #523

Closed
Conduitry opened this issue Apr 25, 2017 · 1 comment · Fixed by #526
Closed

destroy not a valid callee #523

Conduitry opened this issue Apr 25, 2017 · 1 comment · Fixed by #526

Comments

@Conduitry
Copy link
Member

The example given in the guide for yield elements does not work currently, as it attempts to use .destroy() directly in event handlers, which validateElement does not recognize as a valid callee.
@Rich-Harris
Copy link
Member

Good catch — PR inbound

Rich-Harris added a commit that referenced this issue Apr 25, 2017
@Rich-Harris
include destroy as valid built-in method for event handlers (fixes #523)
754688c
@Rich-Harris Rich-Harris mentioned this issue Apr 25, 2017
Merged
Rich-Harris added a commit that referenced this issue Apr 25, 2017
@Rich-Harris
Merge pull request #526 from sveltejs/gh-523
9ae2540 
include destroy as valid built-in method for event handlers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include destroy as valid built-in method for event handlers sveltejs/svelte
2 participants
@Rich-Harris @Conduitry