Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<slot slot="…"> is broken #5475

Closed
TheComputerM opened this issue Sep 30, 2020 · 14 comments
Closed

<slot slot="…"> is broken #5475

TheComputerM opened this issue Sep 30, 2020 · 14 comments
Labels

Comments

@TheComputerM
Copy link

REPL: https://svelte.dev/repl/5acc582e28f04d06aff5f3b861e7537f?version=3.29.0

The component is not compiling.

@dxlbnl
Copy link
Contributor

dxlbnl commented Sep 30, 2020

You've got an error in your sample (as in discord). But you are right.

The compiler hangs on <slot slot="..." />

Example: https://svelte.dev/repl/29959e70103f4868a6525c0734934936?version=3.29.0

@TheComputerM
Copy link
Author

Replacing <slot slot="test" /> with <slot slot="test" name="test" /> also results in the same error.

@damianpumar
Copy link
Contributor

Hi guys, I was reviewing this example in svelte's page https://svelte.dev/tutorial/named-slots and following this issue, I think the correct behaviour is throw an error, right?

Many thanks!

@TheComputerM
Copy link
Author

@damianpumar Nah, its a new feature #2079

@damianpumar
Copy link
Contributor

@damianpumar Nah, its a new feature #2079

Someone has already started to fix it? I can help to fix this issue

@TheComputerM
Copy link
Author

I don't think anyone has started work on this @damianpumar .

@damianpumar
Copy link
Contributor

damianpumar commented Oct 6, 2020

Cool, I will try to fix this, in case I need help I will let you know 👍 @TheComputerM

@TheComputerM
Copy link
Author

Any updates?

@damianpumar
Copy link
Contributor

Good morning guys, Yesterday I talked with @tanhauhau he helped me to discover the problem behind this issue, I'm working on solve it as soon as possible.
The problem is like a stack overflow exception inside a compiler.

Many and special thanks to @tanhauhau for him time!

Thanks!

@TheComputerM
Copy link
Author

I think this should be implemented as a new feature, continued at #5535

@damianpumar
Copy link
Contributor

damianpumar commented Oct 18, 2020

Hello @TheComputerM I fixed this issue, I will push the changes in a few minutes

@Conduitry
Copy link
Member

This should be fixed in 3.29.3 - https://svelte.dev/repl/29959e70103f4868a6525c0734934936?version=3.29.3

@TheComputerM
Copy link
Author

Thank you very much @damianpumar !

@damianpumar
Copy link
Contributor

Thank you very much @damianpumar !

Many thanks to all of you guys!, it was a pleasure. 👍

radicleart added a commit to stacks-network/sbtc-bridge-web that referenced this issue Feb 22, 2023
…errors - rolling back some test code which failed to fix the problem.

problem maybe related to sveltejs/svelte#5475
radicleart added a commit to stacks-network/sbtc-bridge-web that referenced this issue Feb 22, 2023
* See issue 10 - github pages leads to 404 due to server configuration errors.

* See issue 10 - github pages leads to 404 due to server configuration errors - rolling back some test code which failed to fix the problem.
problem maybe related to sveltejs/svelte#5475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants