Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom elements can't contain slot='...' children #827

Closed
Rich-Harris opened this issue Sep 7, 2017 · 0 comments
Closed

custom elements can't contain slot='...' children #827

Rich-Harris opened this issue Sep 7, 2017 · 0 comments
Labels

Comments

@Rich-Harris
Copy link
Member

There are probably a few different ways we need to fix our handling of custom elements (e.g. always using props, instead of attributes, when passing data), this just happens to the be the first one I've run across:

<custom-element>
  <header slot='header'>header header header</header>
</custom-element>

This fails because Svelte thinks the slotted element should belong to a Svelte component, and it can't find one.

@Rich-Harris Rich-Harris added the bug label Sep 7, 2017
Rich-Harris added a commit that referenced this issue Sep 13, 2017
Rich-Harris added a commit that referenced this issue Sep 13, 2017
Rich-Harris added a commit that referenced this issue Sep 16, 2017
Don't slot elements inside custom elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant