Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught SyntaxError: Use of future reserved word in strict mode #838

Closed
vp2177 opened this issue Sep 11, 2017 · 1 comment
Closed

Uncaught SyntaxError: Use of future reserved word in strict mode #838

vp2177 opened this issue Sep 11, 2017 · 1 comment

Comments

@vp2177
Copy link
Contributor

vp2177 commented Sep 11, 2017

When upgrading from 1.38.0 to 1.39.0, app no longer works:

Uncaught SyntaxError: Use of future reserved word in strict mode
function timeRangesToArray(ranges) {
	var array = [];
	for (let i = 0; i < ranges.length; i += 1) {
		array.push({ start: ranges.start(i), end: ranges.end(i) });
	}
	return array;
}

This is because let is emitted in timeRangesToArray()

Rich-Harris added a commit that referenced this issue Sep 12, 2017
Change let -> var, solves #838
@Rich-Harris
Copy link
Member

Thanks — released 1.39.1 and added a check to make sure this doesn't happen again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants