Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic props in svelte:component are not properly updated #9003

Closed
fbasso opened this issue Jul 20, 2023 · 1 comment · Fixed by #9006
Closed

Dynamic props in svelte:component are not properly updated #9003

fbasso opened this issue Jul 20, 2023 · 1 comment · Fixed by #9006
Labels
bug compiler Changes relating to the compiler

Comments

@fbasso
Copy link

fbasso commented Jul 20, 2023

Describe the bug

Hello !

There is a regression between the 4.0.5 and the 4.1.0.

When using the following code:

<svelte:component this={component} {...props} />

The props are not re-evaluated properly. See the REPLs

It's maybe related to #8946 (?)

Reproduction

When you click on the Switch component button, the component value must be updated accordingly.

Fails: https://svelte.dev/repl/ff06036a1ebe42ae8fdd017f99648621?version=4.1.0

Pass: https://svelte.dev/repl/ff06036a1ebe42ae8fdd017f99648621?version=4.0.5

Logs

No response

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (20) x64 13th Gen Intel(R) Core(TM) i7-1370P
    Memory: 20.71 GB / 31.66 GB
  Binaries:
    Node: 20.4.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 3.6.1 - C:\Program Files\nodejs\yarn.CMD
    npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.9 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (114.0.1823.82)
    Internet Explorer: 11.0.19041.1566

Severity

blocking an upgrade

@dummdidumm dummdidumm added bug compiler Changes relating to the compiler labels Jul 20, 2023
dummdidumm pushed a commit that referenced this issue Jul 20, 2023
@fbasso
Copy link
Author

fbasso commented Jul 21, 2023

Thanks for your quick fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug compiler Changes relating to the compiler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants