Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider excluding ::view-transition- from CSS scoping logic #9127

Closed
benmccann opened this issue Aug 21, 2023 · 0 comments · Fixed by #11375
Closed

Consider excluding ::view-transition- from CSS scoping logic #9127

benmccann opened this issue Aug 21, 2023 · 0 comments · Fixed by #11375
Labels
css Stuff related to Svelte's built-in CSS handling
Milestone

Comments

@benmccann
Copy link
Member

Describe the problem

From sveltejs/kit#9605:

Note that we need to add the :root selector before the pseudo-element, otherwise Svelte will scope it to the component.

I'm not that familiar with these APIs or whether this is a good idea, but wanted to note it here so that we don't lose track of it

Describe the proposed solution

Also from sveltejs/kit#9605:

We may want to omit ::view-transition-{old,new,group} from the CSS scoping logic in Svelte 4, so that idiomatic uses of the view transitions API are covered.

Alternatives considered

Status quo of adding the :root selector before the pseudo-element

Importance

nice to have

@benmccann benmccann added this to the 5.x milestone Aug 21, 2023
@benmccann benmccann modified the milestones: 5.x, 5.0 Nov 17, 2023
@dummdidumm dummdidumm added the css Stuff related to Svelte's built-in CSS handling label Feb 22, 2024
dummdidumm added a commit that referenced this issue Apr 29, 2024
view transition pseude selectors are global-like, i.e. they shouldn't be scoped or treated as unused.
In the process of adding support for this, is_root and is_host were consolidated into is_global_like because their usage locations didn't need any differentiation between them (same for the new view transition treatment)

closes #9127
trueadm pushed a commit that referenced this issue Apr 29, 2024
* feat: leave view transition pseudo selectors untouched

view transition pseude selectors are global-like, i.e. they shouldn't be scoped or treated as unused.
In the process of adding support for this, is_root and is_host were consolidated into is_global_like because their usage locations didn't need any differentiation between them (same for the new view transition treatment)

closes #9127

* regenerate types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css Stuff related to Svelte's built-in CSS handling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants