Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte 5: Literal string prop values containing double quote improperly escaped in SSR #9454

Closed
Conduitry opened this issue Nov 14, 2023 · 0 comments · Fixed by #9456
Closed

Svelte 5: Literal string prop values containing double quote improperly escaped in SSR #9454

Conduitry opened this issue Nov 14, 2023 · 0 comments · Fixed by #9456
Labels
bug compiler Changes relating to the compiler
Milestone
5.x

Comments

@Conduitry
Copy link
Member

Describe the bug

In SSR, a prop value that's a literal string has " characters in it HTML-entity escaped when they should not be.

I checked a couple of other characters and didn't see any similar behavior with them, so it's possible it's just the double quote character.

Reproduction

https://svelte-5-preview.vercel.app/#H4sIAAAAAAAACo2OwQrCMBBEf2VZhCiU9l5bQfoZxoO0KQaaZEm2goT8u00LCuLB285jZnYijnpSAetLRHszCms8E2GB_KQswkNNrBYd3Oz7TJrQe018klayNuQ8Q3fX0wCjdwZEWa2q3ILiKG1TfRK22bzkHbVCoqgWurQbN-hRqwFr9rNKxXvMav93Tu9sYIhrOyRoYZevsD98r4iZp1-fr-kFHUxOmBIBAAA=

Logs

No response

System Info

REPL

Severity

annoyance
@Conduitry Conduitry added bug compiler Changes relating to the compiler labels Nov 14, 2023
@benmccann benmccann added this to the 5.x milestone Nov 14, 2023
Rich-Harris added a commit that referenced this issue Nov 15, 2023
@Rich-Harris
only escape attribute values for elements, not components - closes #9454
4a16d62
@Rich-Harris Rich-Harris mentioned this issue Nov 15, 2023
Merged
5 tasks
Rich-Harris added a commit that referenced this issue Nov 15, 2023
@Rich-Harris
fix: only escape attribute values for elements, not components (#9456)
6f6c3a0 
* only escape attribute values for elements, not components - closes #9454

* changeset

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug compiler Changes relating to the compiler
Projects
None yet
Milestone
5.x
Development

Successfully merging a pull request may close this issue.

fix: only escape attribute values for elements, not components sveltejs/svelte
2 participants
@benmccann @Conduitry