Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onrender hook for nested widgets #103

Merged
merged 1 commit into from
Dec 4, 2016
Merged

fix onrender hook for nested widgets #103

merged 1 commit into from
Dec 4, 2016

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Dec 3, 2016

As I thought in #91, there indeed was a bug that onrender was called before a widget was mounted for nested widgets.

I also added a failing test because dynamic widgets are mounted at the wrong position. That is also something that should be fixed by separating create and mount.

@codecov-io
Copy link

codecov-io commented Dec 3, 2016

Current coverage is 90.76% (diff: 100%)

Merging #103 into master will not change coverage

@@             master       #103   diff @@
==========================================
  Files            48         48          
  Lines          1310       1310          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1189       1189          
  Misses          121        121          
  Partials          0          0          

Powered by Codecov. Last update e09a39d...19c376f

@Rich-Harris
Copy link
Member

Yeah, that makes a lot more sense 😆 I'll change _parent to root since that's a more accurate description of what it is (we do use root elsewhere to mean data or state or context, which is pointlessly confusing – should probably unify those)

@Rich-Harris Rich-Harris merged commit 19c376f into sveltejs:master Dec 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants