Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve indexed each array reconcilation #10422

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Feb 7, 2024

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 7, 2024

🦋 Changeset detected

Latest commit: 0a05697

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Could you give a bit of explanation why this change makes sense / it's safe to remove this stuff? @Rich-Harris should probably also have a look at this.

@trueadm
Copy link
Contributor Author

trueadm commented Feb 7, 2024

It's likely due to the fact that we've fixed other parts of the reconcilation around each blocks. :) I can't honestly remember all this code from last year (cold brain atm too), but we can see if this change breaks other things first. I've tried locally and it all seems fine though!

Update: I went through all the old test cases that the original logic aimed to fix and they're all working now without it. The big changes in architecture seem be around the fact we now associate the reconciliation with a single change to the array, whilst previously it was only when the array itself changed. So that looks to have been the correct fix meaning this PR can remove the unnecessary lazy property logic entirely.

@trueadm trueadm merged commit 0e011ad into main Feb 7, 2024
8 checks passed
@trueadm trueadm deleted the indexed-each-reconcile branch February 7, 2024 16:57
MentalGear added a commit to MentalGear/svelte that referenced this pull request Feb 14, 2024
* fix: improve indexed each array reconcilation

* simplify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants