Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oneling optimisation #11274

Closed
wants to merge 2 commits into from
Closed

Conversation

tanhauhau
Copy link
Member

Attempts to implement #10997

There's one failed test, invalid-html-ssr. without the <!--]--> comment, may not be possible to noticed hydration mismatch due to invalid html.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 21, 2024

⚠️ No Changeset found

Latest commit: 7d3c1a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

Thanks! Unfortunately I'm seeing quite a few more tests failing — 14 in total

@@ -60,6 +60,7 @@ export interface ComponentClientTransformState extends ClientTransformState {
};
readonly preserve_whitespace: boolean;

readonly optimisation_oneling: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a comment. I 'm not sure I'd know what optimisation_oneling meant from the name alone

@trueadm
Copy link
Contributor

trueadm commented Jul 5, 2024

Closing as stale.

@trueadm trueadm closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants