Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve component function context #12089

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

dummdidumm
Copy link
Member

We need to pass the SFC component function to the snippet dev time function or else nested snippets result in the wrong context being set

fixes #12040

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

We need to pass the SFC component function to the snippet dev time function or else nested snippets result in the wrong context being set

fixes #12040
Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: ef5eeea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm trueadm merged commit fcf81b1 into main Jun 19, 2024
8 checks passed
@Conduitry Conduitry deleted the binding-validation-fix branch July 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Double nested component with array bind leads to ownership_invalid_mutation warning
2 participants