skip missing property warning for computed/global properties #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1246 +/- ##
=========================================
+ Coverage 91.89% 91.9% +<.01%
=========================================
Files 126 126
Lines 4554 4556 +2
Branches 1485 1486 +1
=========================================
+ Hits 4185 4187 +2
Misses 153 153
Partials 216 216
Continue to review full report at Codecov.
|
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Svelte was generating
<Thing> was created without expected data property 'foo'warnings in dev mode for computed properties and globals, which is unnecessary as they're guaranteed to be present