Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only update component props if they are dynamic #1401

Merged
merged 1 commit into from
May 3, 2018
Merged

Conversation

Rich-Harris
Copy link
Member

fixes #1394

@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #1401 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1401      +/-   ##
=========================================
- Coverage   91.25%   91.2%   -0.06%     
=========================================
  Files         122     122              
  Lines        4485    4481       -4     
  Branches     1385    1382       -3     
=========================================
- Hits         4093    4087       -6     
  Misses        154     154              
- Partials      238     240       +2
Impacted Files Coverage Δ
src/compile/nodes/Component.ts 95.19% <ø> (-0.46%) ⬇️
src/compile/nodes/Attribute.ts 86.02% <100%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec21f7...6ddfc19. Read the comment docs.

@Rich-Harris Rich-Harris merged commit b64d730 into master May 3, 2018
@Rich-Harris Rich-Harris deleted the gh-1394 branch May 3, 2018 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Literals in props should not be updated
2 participants