Position nodes absolutely when outroing them, if animations are involved #1457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best shown with a GIF:
There's a little bit of magic here, which you opt in to when you use the
animate
directive. There could be some situations where this approach results in glitchiness, though I can't think of any off the top of my head. (Maybe if the node already has transforms involving scaling/rotation etc?)This is a little tricky to test with JSDOM... not sure if there's a great way around that 😬
TODO:
updateKeyedEach
fromEachBlock
, so that apps that aren't usinganimate
don't have to bear the extra weight