fix Literally undefined class #3283 #3319
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literally undefined class #3283
Added check for className. In compiled file its look like:
Its no option to modify ‘attr’ function because it gets concatenated className string from image above (null + " svelte-abc"):
:
I prefer logical 'or' to ternary operator because className token may be a function with side effects and we will call function twice:
I think in future we must add special class name resolver function. Also added tests.
Thanks