Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm marking this [WIP] because I'm a little unsure of my change here still, but also because the unit test is still failing for some reason. I see some other unit tests involving
<select>
have been disabled, apparently because of limitations or bugs in jsdom.The specific test cases (REPL, REPL) seem to work with this change when they're compiled and manipulated manually - and no other unit tests break.
The idea in the PR is to move all of the attribute handling of
<select>
elements (attaching event handlers, etc) after the code for handling its children - but within that code generated by visiting the attributes to keep everything in the same relative order as it is for other types of elements. I can't see what any unpleasant side-effects of this might be, but there could still be some. As a bonus, the generation code inElement.js
is slightly tidier.cc @saibotsivad @TehShrike