Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn for possible misname component to lowercase #5302

Merged
merged 5 commits into from
Sep 29, 2020

Conversation

tanhauhau
Copy link
Member

eg:

<script>
  import thisShouldWarnMe from './MyComponent.svelte';
</script>

<thisShouldWarnMe />

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry
Copy link
Member

I'm a little concerned about false positives, like

<script>
	let i;
</script>

<i>Hello world</i>

Is there a reasonable way to better characterize the situations where a mistake is likely being made? Maybe only if the variable in question is an import?

@tanhauhau
Copy link
Member Author

@Conduitry updated 👍

@Conduitry Conduitry merged commit 2d88dc4 into sveltejs:master Sep 29, 2020
@Conduitry
Copy link
Member

This warning is now included in 3.29.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants