Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support methods as action #5398

Merged
merged 4 commits into from
Sep 18, 2020
Merged

support methods as action #5398

merged 4 commits into from
Sep 18, 2020

Conversation

tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented Sep 15, 2020 •
edited
Loading

Fixes #5395
Fixes #3935

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit 254096d into sveltejs:master Sep 18, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
@tanhauhau @taylorzane
support methods as actions (sveltejs#5398)
997857c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tanhauhau @Conduitry