Simpler codegen #559
Merged
Simpler codegen #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 88.2% 87.98% -0.22%
==========================================
Files 95 95
Lines 2933 2855 -78
==========================================
- Hits 2587 2512 -75
+ Misses 346 343 -3
Continue to review full report at Codecov.
|
|
FWIW, that's much easier for me to follow, and offspring have robbed me of a fair amount of my diminishing brain power 😃. It's kinda like debugging with source maps vs without. |
|
Yep, feels much nicer! And a good bit less code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I snuck into #525 — if an expression in a
deindenttemplate literal is falsy, it will a) ignore it and b) remove the preceding whitespace. This makes it much easier to write codegen code that actually resembles the output — it's far more compact and (I think) easier to follow.Have also updated
deindentso that if an expression is an array, it gets joined (with a newline separator) automatically, reducing noise.Some of the
&&expressions in this PR probably shouldn't be inlined the way they are, but at least this gives us a bit more flexibility to find the most readable approach.