Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark nest method this: void for destructing safely #6094

Merged
merged 1 commit into from
Mar 24, 2021
Merged

chore: mark nest method this: void for destructing safely #6094

merged 1 commit into from
Mar 24, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 18, 2021

close sveltejs/eslint-plugin-svelte3#102

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@frederikhors
Copy link

frederikhors commented Mar 18, 2021

Thank you @JounQin and @dummdidumm, can we merge and release this please? I have dozens of projects with thousands of warnings in CI! 🤣

@JounQin
Copy link
Contributor Author

JounQin commented Mar 24, 2021

@dummdidumm Can this PR been merged?

@dummdidumm dummdidumm merged commit 50dcc2a into sveltejs:master Mar 24, 2021
@JounQin JounQin deleted the fix/this_void branch March 24, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants