fix custombutton colors for a11y contrast #6212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share a screenshot of the before and after? |
|
Sure, @benmccann. Here's a screenshot illustrating the current/proposed styles. The proposed colors have a contrast of 4.53, which results in compliance with WCAG standards.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color contrast between the current
CustomButton'sbackground-color(#aaa) andcolor/border-color(#f1c40f) does not meet the minimum WCAG criteria. It fails the WCAG AA Standard with a contrast ratio of 1.4.Since it's kind of hard to meet the contrast ratio standard by keeping a vibrant yellow color (similar to the current one) and a light background, I consider it better to switch the yellow color for an orange/tan color (similar to the Svelte color) and a lighter background color, so it passes WCAG AA.