-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing tutorial - HTML and CSS order and button style #6213
Conversation
- Also making the button simple and prettier.
- Also making the button simple and prettier.
What was the motivation for these changes? Also, if the html/css order is changed in one place, it should be changed in all places of the tutorial to be consistent - but I'm not sure that's something we want at this point, at least there needs to be some concensus if that's a desired change. |
Why I changed the HTML and CSS order?Because there is nothing related to CSS in this tutorial. So the target is the button element and users must see it first. in prev code, the user should scroll to see the HTML code but now the user can see it on the first look. What about styling?The old button was ugly and distracting. It can be a good choice if we remove all the styles because this tutorial isn't related to CSS and [+] it can be less distracting to the user. |
Changing it because "it's more important" will be confusing. The purpose of the tutorial is to get familiar with Svelte in general, and switching up script/style/html order on a case-by-case-basis does not help there. That's why we need to be consistent. |
Agree with consistency and having a good style. <script></script>
<p>Hello, World!</p>
<style></style> But in the tutorial, we do not comply with it. So I think the best decision is to correct the ordering in all the tutorials and the examples and anywhere else. |
What the standard is is not totally fixed, |
@dummdidumm
|
Script comes first both in the current Svelte tutorial and the default formatting, so I vote for script-html-style |
Hi |
Oh God, I didn't know that the new commit going to affect this pull request. |
- Changing paragraph content. - Changing comment.
- Changing paragraph content.
- Changing paragraph content.
- Changing paragraph content.
- Changing paragraph content.
- Format CSS
- Format CSS
- Format CSS
- Format CSS
All done. I Just changed:
|
I have a question, why the tutorials and the examples are the same? I mean 90 of them are duplicates!. |
I don't know honestly, but I guess because not everyone will look at the tutorial so there needs to be some overlap. Thanks for rearranging all these! I see however that you do some slight adjustments along the way, like changing |
Sure. |
Ok, all done. |
Thanks! |
Hi. The result of changes: