Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loose parsing mode #6728

Open
wants to merge 1 commit into
base: svelte-4
Choose a base branch
from

Conversation

dummdidumm
Copy link
Member

Related to #4818

Adds a loose parsing mode which will continue parsing no matter what. In loose mode, the first error that is encountered is part of the return in case subsequent analysis of the result cannot be performed and a fallback to the original error is needed.
This would enable sveltejs/language-tools#1177
It's up to discussion whether the naming is good and whether or not additional parsing fallbacks should be applied in loose mode (this is the simplest implementation as a start for now).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@dummdidumm dummdidumm added this to the one day milestone Feb 22, 2023
@benmccann benmccann changed the title [feat] add loose parsing mode feat: loose parsing mode Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant