Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: missing null value of append_styles in init function #6828

Conversation

zhiyue-yi
Copy link

@zhiyue-yi zhiyue-yi commented Oct 9, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

Hi. When I was using svelte-navigator, I encountered this issue: Uncaught TypeError: append_styles is not a function and there was an issue created in svelte-navigator here: mefechoel/svelte-navigator#47

image

Here is the repo to reproduce the issue: https://github.com/ZhiyueYi/web-toolbox

I think the issue was introduced by this MR: #5870 which didn't handle default case of append_styles well at src/compiler/compile/render_dom/index.ts#L546 in this MR

@zhiyue-yi zhiyue-yi changed the title [fix]: missing null value of append_styles in init function WIP: [fix]: missing null value of append_styles in init function Oct 9, 2021
@zhiyue-yi zhiyue-yi changed the title WIP: [fix]: missing null value of append_styles in init function [fix]: missing null value of append_styles in init function Oct 9, 2021
@zhiyue-yi zhiyue-yi closed this Oct 9, 2021
@zhiyue-yi zhiyue-yi deleted the fix/missing-append-styles-in-init-function branch October 10, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant