-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] dispatch cancelable custom events #7064
Conversation
TQSM for this PR. Can you specify how we can detect whether an event was cancelled? As far as I know, you need the |
Good point. |
Updated to return a |
Updated docs, changelog and fixed the types. This should be good to go (unless there's some wording changes). |
Conduitry, I've requested your review in case you want to take a look at this. In the last maintainer's meeting, we had agreed that this would be a safe addition to the API. |
Fixes #4623
Dispatching custom events can be cancelled.
Before submitting the PR, please make sure you do the following
[feat]
,[fix]
,[chore]
, or[docs]
.Tests
npm test
and lint the project withnpm run lint