Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract some shared init logic #855

Merged
merged 4 commits into from
Sep 17, 2017
Merged

extract some shared init logic #855

merged 4 commits into from
Sep 17, 2017

Conversation

Rich-Harris
Copy link
Member

Some low-hanging fruit — rather than repeating this._handlers = Object.create(null) etc, we can just move that out into a shared init function. We could be more aggressive if we didn't mind having this._slotted and this.refs on all components, whether or not they're used (might mean modest savings on large apps that used those things, at the expense of ones that didn't) — for now, sticking to more unambiguous wins.

@Rich-Harris Rich-Harris merged commit f394cac into master Sep 17, 2017
@Rich-Harris Rich-Harris deleted the shared-init branch September 17, 2017 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant