Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perf): use classList.toggle instead of add/remove #8629

Merged
merged 8 commits into from
May 26, 2023
Merged

fix(perf): use classList.toggle instead of add/remove #8629

merged 8 commits into from
May 26, 2023

Commits on May 9, 2023

  1. feat: add workflow to trigger ecosystem-ci from svelte PRs (sveltejs#… 

    …8571)
    @dominikg
    dominikg authored May 9, 2023
    Configuration menu
    Copy the full SHA
    3bc791b View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. fix(perf): use classList.toggle instead of shenanigans 

    `classList.toggle(..., flag)` has been a part of the DOM standard forever,
so better use it instead of possibly causing browser deopts by using dynamic attribute access.
The `!!` is required because an `undefined` flag means flipping the current state.
    @akx
    akx committed May 24, 2023
    Configuration menu
    Copy the full SHA
    235e512 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/version-4' into toggle-class-t… 

    …oggle
    @benmccann
    benmccann committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c3b1e5b View commit details
    Browse the repository at this point in the history

  3. remove file that snuck onto PR

    @benmccann
    benmccann committed May 24, 2023
    Configuration menu
    Copy the full SHA
    07ef0af View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Update src/runtime/internal/dom.js 

    Co-authored-by: Rich Harris <hello@rich-harris.dev>
    @dummdidumm @Rich-Harris
    dummdidumm and Rich-Harris authored May 26, 2023
    Configuration menu
    Copy the full SHA
    7df1e06 View commit details
    Browse the repository at this point in the history

  2. changelog

    @dummdidumm
    dummdidumm authored May 26, 2023
    Configuration menu
    Copy the full SHA
    4830d59 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'version-4' into toggle-class-toggle

    @dummdidumm
    dummdidumm authored May 26, 2023
    Configuration menu
    Copy the full SHA
    faefbe4 View commit details
    Browse the repository at this point in the history

  4. Update src/runtime/internal/dom.js

    @dummdidumm
    dummdidumm authored May 26, 2023
    Configuration menu
    Copy the full SHA
    79c31c3 View commit details
    Browse the repository at this point in the history