site: make REPL user menu keyboard accessible #8831
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes sveltejs/sites#494
The current user menu in the REPL wasn't keyboard- or AT- accessible since it only activated on hover. I refactored it to activate on click/button trigger instead. Clicking outside or moving focus outside the menu auto-closes it.
Briefly toyed around with also activating it on hover, but that made things too confusing. I think the chevron icon is a clear enough indication that this is interactable (and on mobile you had to tap it anyway).
Some of the icons increase opacity on hover - I updated things to increase opacity on focus as well.
Also refactored some of the styles to use flexbox, since that made things cleaner.
Since this PR bumps site-kit, it also includes a few changes from the latest release (removing the background blur on the search overlay and fixing the double-underline on nav links)
Screenshots
Desktop
Mobile
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint