Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supported "muted" property as boolean on audio element #886

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

m59peacemaker
Copy link
Contributor

@m59peacemaker m59peacemaker commented Oct 5, 2017

The MDN HTML attribute reference didn't include the audio element under the muted property. I updated the MDN reference and inserted audio here, too. Without this, muted={{ false }} will render the muted property on audio elements, thus muting them (demo).

I didn't see any tests for this sort of thing, so I didn't write one.

Is there a script I missed that parses the mdn page for this data? If not, would it be helpful to have one? I might be able to do that shortly.

@Rich-Harris Rich-Harris merged commit d01d7ee into sveltejs:master Oct 17, 2017
@Rich-Harris
Copy link
Member

thanks!

Is there a script I missed that parses the mdn page for this data?

No, nothing as fancy as that — IIRC I just copied and pasted the table into VSCode and beat it into shape with a bunch of regular expressions. A script would probably have been the smarter way to go...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants