Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: choose a color that looks great on both dark and light theme #8921

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

tanhauhau
Copy link
Member

Before submitting the PR, please make sure you do the following

tried a middle color that seems to work for both dark and light theme.
not sure if this is better, or we should specify different colors for different dark / light theme

before:
Screenshot 2023-07-06 at 9 04 59 AM
Screenshot 2023-07-06 at 9 05 04 AM

after:
Screenshot 2023-07-06 at 9 04 50 AM
Screenshot 2023-07-06 at 9 04 42 AM

relates to sveltejs/sites#493

- [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs

  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
    - [ ] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

- [ ] Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm dummdidumm merged commit a23fcc0 into sveltejs:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants