Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow svelte:self in snippets #9439

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: allow svelte:self in snippets #9439

merged 2 commits into from
Nov 14, 2023

Conversation

paoloricciuti
Copy link
Member

This closes #9436 however i'm not entirely sure we should do this.

On one hand is reasonable to be able to render <svelte:self /> inside a snippet that is than passed to a component even without an if block. On the other this remove a safe security pin against infinite loops if i do something like

{#snippet infinite()}
<svelte:self />
{/snippet}

{@render infinite()}

at the same time this is still doable by doing this

{#snippet infinite()}
    {#if true}
        <svelte:self />
    {/if}
{/snippet}

{@render infinite()}

For the moment i've opened this PR but i leave this to the wise minds of the maintainers to decide what's best to do.

P.s. i did not include a test to check for this behavior because i didn't see tests to check that svelte:self is allowed inside the other blocks....but i can add one for all the cases if needed.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: e7a044d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 14, 2023

@paoloricciuti is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to allow it like this. Static analysis can only get you so far when preventing infinite loops.

@Rich-Harris Rich-Harris merged commit e90ded6 into sveltejs:main Nov 14, 2023
5 of 7 checks passed
@Rich-Harris
Copy link
Member

nice, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: <svelte:self /> can't be directly added to a {#snippet}
3 participants