fix: allow svelte:self in snippets #9439
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #9436 however i'm not entirely sure we should do this.
On one hand is reasonable to be able to render <svelte:self /> inside a snippet that is than passed to a component even without an if block. On the other this remove a safe security pin against infinite loops if i do something like
at the same time this is still doable by doing this
For the moment i've opened this PR but i leave this to the wise minds of the maintainers to decide what's best to do.
P.s. i did not include a test to check for this behavior because i didn't see tests to check that svelte:self is allowed inside the other blocks....but i can add one for all the cases if needed.
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint