Code golf each transitions #9476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 87b3bab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
force-pushed
the
code-golf-each-transitions
branch
from
2931dde
to
99e3cc7
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
reviewed
Nov 15, 2023
| @@ -1863,6 +1845,7 @@ function await_block(anchor_node, input, pending_fn, then_fn, catch_fn) { | |||
| return; | |||
| } | |||
| const transitions = render.transitions; | |||
| remove_in_transitions(transitions); | |||
There was a problem hiding this comment.
how come we added this here and on line 1994? was there a bug before?
There was a problem hiding this comment.
I just noticed we weren't doing it lol. We should have been.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the codesize of each blocks and general transition stuff by moving it to either be lazy or shared.