Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'current' to the list of aria attributes #953

Merged
merged 1 commit into from
Nov 25, 2017
Merged

Add 'current' to the list of aria attributes #953

merged 1 commit into from
Nov 25, 2017

Conversation

EmilTholin
Copy link
Member

@EmilTholin EmilTholin commented Nov 25, 2017

This PR adds current to the list of aria attributes, so that Svelte doesn't give a A11y: Unknown aria attribute 'aria-current' warning when aria-current is used.

@codecov-io
Copy link

Codecov Report

Merging #953 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         109      109           
  Lines        4010     4010           
  Branches     1287     1287           
=======================================
  Hits         3679     3679           
  Misses        148      148           
  Partials      183      183
Impacted Files Coverage Δ
src/validate/html/a11y.ts 94.93% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b27b7...1d76b71. Read the comment docs.

@Rich-Harris Rich-Harris merged commit ede70be into sveltejs:master Nov 25, 2017
@Rich-Harris
Copy link
Member

Thank you!

@EmilTholin EmilTholin deleted the a11y_aria_current branch November 25, 2017 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants