Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some unused code #9593

Merged
merged 1 commit into from
Nov 22, 2023
Merged

chore: remove some unused code #9593

merged 1 commit into from
Nov 22, 2023

Conversation

Rich-Harris
Copy link
Member

this removes some funky stuff that shouldn't really have been there in the first place, and which is surplus to requirements now that esrap has been updated

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: b8e78ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 6:43pm

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably an overlook while copying over the code from the old code base, where has_trailing_newline had meaning for something (which I don't know what for)

@dummdidumm dummdidumm merged commit 1f4ae5e into main Nov 22, 2023
8 checks passed
@dummdidumm dummdidumm deleted the tidy-up-esrap-leftovers branch November 22, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants