Adding holidays in Morocco #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3288f00.
BelmoMusta
commented
Jan 13, 2020
| @@ -94,6 +94,9 @@ public void parse(int year, Set<Holiday> holidays, final Holidays config) { | |||
| case MAWLID_AN_NABI: | |||
| islamicHolidays = calendarUtil.getIslamicHolidaysInGregorianYear(year, 3, 12); | |||
| break; | |||
| case MAWLID_AN_NABI_2: | |||
There was a problem hiding this comment.
As for Morocco, this date has 2 days off
hakan42
reviewed
Jan 13, 2020
src/main/resources/descriptions/holiday_descriptions_en.properties
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used this library in one of my projects where I needed to know if a date in France is holiday, after that, I had a similar need but for a different country : Morocco. So I decided to add the definition of moroccan holidays