Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing unions when child of namespace #40

Merged
merged 4 commits into from
Aug 2, 2018
Merged

Fix missing unions when child of namespace #40

merged 4 commits into from
Aug 2, 2018

Conversation

svenevs
Copy link
Owner

@svenevs svenevs commented Aug 2, 2018 •
edited
Loading

Fixes #37.

  • Add a test case to reflect this in cpp_nesting
  • Verify all files are generated and included in the library root document.
  • Unstash the fixing changes xD

@svenevs
add test_common method, remove test_app methods
9f34483 
- move get_exhale_root to testing/__init__.py from hierarchies.py
- metaclass adds test_common method that issues common checks
  when a class is not marked with @no_ron
    - currently runs self.{checkRequiredConfigs,checkAllFilesGenerated}
    - test_app methods were just running checkRequiredConfigs,
      so they are removed or renamed.
@svenevs
analagous test for v0.2.0 ExhaleCompanion breakage
4d2932e
@svenevs
simplify logic for calling generateSingleNodeRST
1546e3c
@svenevs svenevs force-pushed the fix/missing-unions branch 3 times, most recently from c62da17 to d7f53c3 Compare August 2, 2018 18:02
@svenevs
check unabridged_api, autotested directive, skip extra CI builds
27ed177 
- verify that every generated file is included in the
  unabridged_api.rst file
- add .. autotested:: directive extension for denoting that the
  given methods do not need to be called directly for new test cases
- stop building extra CI jobs for internal PRs
@svenevs svenevs merged commit 227496e into master Aug 2, 2018
@svenevs svenevs deleted the fix/missing-unions branch August 2, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You broke unions you fool (KeyError: 'auto' in self.project_info_for_auto_store[name])!
1 participant
@svenevs