Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sardinian (sc) translations #1030

Merged
merged 7 commits into from
Sep 10, 2022
Merged

Add Sardinian (sc) translations #1030

merged 7 commits into from
Sep 10, 2022

Conversation

asereze
Copy link
Contributor

@asereze asereze commented Sep 1, 2022

No description provided.

@pama pama self-requested a review September 2, 2022 10:55
@digitalfrost
Copy link
Collaborator

digitalfrost commented Sep 8, 2022

@digitalfrost
Copy link
Collaborator

These keys will be added to the en.yml via this pull request:
#1042

@pama
Copy link
Collaborator

pama commented Sep 8, 2022

@digitalfrost shall we merge this one?

@asereze
Copy link
Contributor Author

asereze commented Sep 9, 2022

@digitalfrost Could you please give me some context about what those two strings mean? I need an example sentence for errors.messages.in and an explanation about what the default value in number.format.round_mode actually does. Since it looks like those strings are missing in all other locales I have no other examples to use for comparison. Anyway you could also merge this now and then I could just add those strings to the file later, when #1042 will be merged.

@pama
Copy link
Collaborator

pama commented Sep 9, 2022

@asereze you can find the Ruby on Rails default translations here: https://github.com/svenfuchs/rails-i18n/tree/master/rails/rails

@asereze
Copy link
Contributor Author

asereze commented Sep 9, 2022

@pama I didn't find a clear explanation there, the comment for number.format.round_mode is # Determine how rounding is performed (see BigDecimal::mode) but where can I find BigDecimal::mode? I need to know what the values are to be able to know if "default" is applicable to Sardinian. And errors.messages.in doesn't have an example or explanation. Could you please tell me how "must be in %{count}" could be used?

@pama
Copy link
Collaborator

pama commented Sep 9, 2022

@asereze for in see https://guides.rubyonrails.org/active_record_validations.html#numericality and search for "must be in".

for round_mode, it's used with helpers like number_to_human, and you can learn more about BigDecima::mode in the stdlib documentation. I don't see a reason to use something else besides the default, but I will let that to you :)

@asereze
Copy link
Contributor Author

asereze commented Sep 9, 2022

@pama Oh, ok, so %{count} is an interval in that case! Thank you very much, that was what I needed. I've just added those two strings.

@pama
Copy link
Collaborator

pama commented Sep 10, 2022

@asereze we are getting errors when running the tests, is this something you can fix? Thanks!

@digitalfrost
Copy link
Collaborator

It's failing on

locale file is expected to be a subset of "rails/locale/en.yml"

because it is expecting the two new keys errors.messages.in and number.format.round_mode to be in en.yml

They have now be added to en.yml via 9925252 and 53b5095

@pama pama merged commit f872e9a into svenfuchs:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants