Make rails-i18n work with rails7 #957
Conversation
| @@ -16,7 +16,7 @@ Gem::Specification.new do |s| | |||
| s.required_rubygems_version = '>= 1.8.11' | |||
|
|
|||
| s.add_runtime_dependency('i18n', '>= 0.7', '< 2') | |||
| s.add_runtime_dependency('railties', '>= 6.0.0', '< 7') | |||
| s.add_runtime_dependency('railties', '>= 7.0.0', '< 8') | |||
There was a problem hiding this comment.
Since everything still works with rails 6, I think we should only relax the upper limit and not restrict the lower one i.e.
s.add_runtime_dependency('railties', '>= 6.0.0', '< 8')
There was a problem hiding this comment.
Agreed, supporting both Rails 6 and 7 will help with transitioning.
There was a problem hiding this comment.
@f6p can you please do this small change?
There was a problem hiding this comment.
I think it should just be >= 6 so that it's compatible with future versions of rails in an "evergreen" setup
- Add runtime railties 7.0.0 dependency. - Bump version number to 7.0.0. - Update Gemfile.lock.
|
I removed ordinal changes as now there is a better PR for that (#958). |
|
Guys as a temporary quickfix we are using this in our Gemfile: Its my branch that merges #958 and this one (#957) and works well for us. No need to wait for official release (you can switch to official gem at later time). Hope this helps at least some of you. |
|
@f6p sure, but can you please do this small change in this PR? #957 (comment) |
|
Closing this in favour of #962 |
EDIT: Temp Quickfix
In your Gemfile replace
gem 'rails-i18n'withgem 'rails-i18n', git: 'https://github.com/f6p/rails-i18n.git', branch: 'rails7-hotfix'. See my comment below.Original PR message
Rails7 was released today. gemspec has hardcoded depndency
rails < 7. As a consequence bundler can resolve dependencies on release candidates but not on stable release.PR is similar to #955 but does two more things. It updates
Gemfile.lock(I ran specs - one translation seems to be missing) and fixes invalid hash syntax inrails/ordinals(that caused errors when testing application with rails-i18n dependency).It fixes #954, replaces: #955.
Cheers
馃嵎