Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split icon and prefix features into new pencil package #18

Closed
svengreb opened this issue Sep 26, 2020 · 0 comments · Fixed by #19
Closed

Split icon and prefix features into new pencil package #18

svengreb opened this issue Sep 26, 2020 · 0 comments · Fixed by #19
Labels
context-pkg scope-quality scope-ux type-feature
Milestone
0.1.0

Comments

@svengreb
Copy link
Owner

Currently the inkpen package provides a writer that is able to print verbosity level icons and prefixes with colors. To allow to use icons and prefixes without colors both features will be moved into a new pencil package with a new pencil.Pencil type. The inkpen.Inkpen type will be changed to compose this new type and additionally allows to color the output.

In order to make it easier to configure both types, new package specific options will be implemented that will be available via variadic parameters to the constructor functions of these types. This reduces the required code to configure a writer and also provides a safer usage with Goroutines.
@svengreb svengreb added this to the 0.1.0 milestone Sep 26, 2020
@svengreb svengreb self-assigned this Sep 26, 2020
svengreb added a commit that referenced this issue Sep 28, 2020
@svengreb
Split icon and prefix features into new pencil package
2f04a9c 
Before the `inkpen` package provided a writer that was able to print
verbosity level icons and prefixes with colors.
To allow to use icons and prefixes without colors both features have
been moved into the new `pencil` package with the new `pencil.Pencil`
type. The `inkpen.Inkpen` type has been changed to compose this new type
and additionally allow to color the output.

In order to make it easier to configure both types, new package specific
options have been implemented that are available via variadic parameters
to the constructor functions of these types. This reduces the required
code to configure a writer and also provides a safer usage with
Goroutines.

GH-18
@svengreb svengreb mentioned this issue Sep 28, 2020
Merged
svengreb added a commit that referenced this issue Sep 28, 2020
@svengreb
Split icon and prefix features into new pencil package (#19)
4f97c4c 
Before the `inkpen` package provided a writer that was able to print
verbosity level icons and prefixes with colors.
To allow to use icons and prefixes without colors both features have
been moved into the new `pencil` package with the new `pencil.Pencil`
type. The `inkpen.Inkpen` type has been changed to compose this new type
and additionally allow to color the output.

In order to make it easier to configure both types, new package specific
options have been implemented that are available via variadic parameters
to the constructor functions of these types. This reduces the required
code to configure a writer and also provides a safer usage with
Goroutines.

Resolves GH-18
@svengreb svengreb removed their assignment Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-pkg scope-quality scope-ux type-feature
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

Split icon and prefix features into new pencil package svengreb/nib
1 participant
@svengreb