Optimize OS and Go version matrix strategy for CI workflow #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before the CI workflow used a matrix strategy to run the `lint-node`, `lint-go` and `test` jobs, but this also included steps that were not necessary for this repository. This has been improved to make the workflow run faster by avoiding unnecessary tasks: - The `lint-node` job has been changed to only run on the currently latest stable Node version `14.x` [1] only on Linux because this repository is not focused on JavaScript but only runs Node based tools to lint other files within this repository. - The `lint-go` job has been changed to only run on the currently latest stable Go version `1.15.x` [2] only on Linux because `golangci-lint` doesn't care about the Go version and OS it runs on but only statically checks the source code. - The `test` job has been changed to only run on the currently latest stable Go version `1.15.x` [2] and only Linux and Windows while macOS is not necessary for this repository because there is no macOS specific code. These changes also help to keep the required GitHub Action run minutes for the account of this repository as small as possible without wasting resources for unnecessary tasks. [1]: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#14.12.0 [2]: https://golang.org/doc/go1.15 GH-12
svengreb
deleted the
improvement/gh-12-optimize-os-and-go-matrix-strategy-ci-workflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12