Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pencil.NewFrom(*pencil.Options) function #24

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Remove pencil.NewFrom(*pencil.Options) function #24

merged 1 commit into from
Oct 31, 2020

Conversation

svengreb
Copy link
Owner

Resolves #23

@svengreb
Remove pencil.NewFrom(*pencil.Options) function
493d74d 
The `pencil.NewFrom(*pencil.Options)` [1] function was not necessary
because...

1. ...there was no way to get the actual options from a `pencil`
   instance.
2. ...new `pencil` instances with different options can be simply
   composed ny using the variadic parameter of the
   `pencil.New(pencil.Option...)` function.

Therefore the `pencil.NewFrom(*pencil.Options)` has been removed to
simply the package surface.

[1]: https://github.com/svengreb/nib/blob/2dac3395/pencil/pencil.go#L26-L27

GH-23
@svengreb svengreb added this to the 0.2.0 milestone Oct 31, 2020
@svengreb svengreb self-assigned this Oct 31, 2020
@svengreb svengreb merged commit 175478e into main Oct 31, 2020
@svengreb svengreb deleted the improvement/gh-23-remove-pencil-newfrom-func branch October 31, 2020 13:33
@svengreb svengreb removed their assignment Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
context-pkg scope-maintainability scope-quality type-improvement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Remove pencil.NewFrom(*pencil.Options) function
1 participant
@svengreb