Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to golangci-lint v1.39.x #56

Closed
svengreb opened this issue Apr 26, 2021 · 0 comments · Fixed by #57
Closed

Update to golangci-lint v1.39.x #56

svengreb opened this issue Apr 26, 2021 · 0 comments · Fixed by #57

Comments

@svengreb
Copy link
Owner

The currently latest golangci-lint version 1.39.0 introduced new linters and updated supported ones:

  1. predeclared (v1.35.0) — Checks for definitions and declarations that shadows one of Go's pre-declared identifiers.
    This linter is disabled by default, but will be enabled for this template to help to prevent shadowed identifiers.
  2. interfacer (v1.38.0) — Has been deprecated and will be removed from the enabled linter in this template.
  3. scopelint (v1.39.0) — Has been deprecated and will be replaced by exportloopref.
    The exportloopref linter is disabled by default, but will be enabled for this template to help to catch loop variable bugs.
@svengreb svengreb added this to the Next milestone Apr 26, 2021
@svengreb svengreb self-assigned this Apr 26, 2021
svengreb added a commit that referenced this issue Apr 26, 2021
The currently latest `golangci-lint` version 1.39.0 [1] introduced new
linters and updated supported ones:

1. predeclared [2] (v1.35.0 [3]) - Checks for definitions and
   declarations that shadows one of Go's pre-declared identifiers [4].
   This linter is disabled by default, but is enabled for this template
   to help to prevent shadowed identifiers.
2. interfacer [5] (v1.38.0 [6]) - Has been deprecated [7] and removed
   from this template.
3. scopelint [8] (v1.39.0 [9]) - Has been deprecated [10] and replaced
   by exportloopref [11].
   The `exportloopref` linter is disabled by default, but is enabled for
   this template to help to catch loop variable bugs.

[1]: https://github.com/golangci/golangci-lint/releases/tag/v1.39.0
[2]: https://github.com/nishanths/predeclared
[3]: https://github.com/golangci/golangci-lint/releases/tag/v1.35.0
[4]: https://golang.org/ref/spec#Predeclared_identifiers
[5]: https://github.com/mvdan/interfacer
[6]: https://github.com/golangci/golangci-lint/releases/tag/v1.38.0
[7]: golangci/golangci-lint#1755
[8]: https://github.com/kyoh86/scopelint
[9]: https://github.com/golangci/golangci-lint/releases/tag/v1.39.0
[10]: golangci/golangci-lint#1819
[11]: https://github.com/kyoh86/exportloopref

GH-56
svengreb added a commit that referenced this issue Apr 26, 2021
The currently latest `golangci-lint` version 1.39.0 [1] introduced new
linters and updated supported ones:

1. predeclared [2] (v1.35.0 [3]) - Checks for definitions and
   declarations that shadows one of Go's pre-declared identifiers [4].
   This linter is disabled by default, but is enabled for this template
   to help to prevent shadowed identifiers.
2. interfacer [5] (v1.38.0 [6]) - Has been deprecated [7] and removed
   from this template.
3. scopelint [8] (v1.39.0 [9]) - Has been deprecated [10] and replaced
   by exportloopref [11].
   The `exportloopref` linter is disabled by default, but is enabled for
   this template to help to catch loop variable bugs.

[1]: https://github.com/golangci/golangci-lint/releases/tag/v1.39.0
[2]: https://github.com/nishanths/predeclared
[3]: https://github.com/golangci/golangci-lint/releases/tag/v1.35.0
[4]: https://golang.org/ref/spec#Predeclared_identifiers
[5]: https://github.com/mvdan/interfacer
[6]: https://github.com/golangci/golangci-lint/releases/tag/v1.38.0
[7]: golangci/golangci-lint#1755
[8]: https://github.com/kyoh86/scopelint
[9]: https://github.com/golangci/golangci-lint/releases/tag/v1.39.0
[10]: golangci/golangci-lint#1819
[11]: https://github.com/kyoh86/exportloopref

Closes GH-56
@svengreb svengreb removed their assignment Apr 26, 2021
svengreb added a commit to svengreb/wand that referenced this issue Apr 27, 2021
Updated to `tmpl-go` version `0.8.0` [1] which updated `golangci-lint`
to version `1.39.0` [2] and the `tmpl` repository version `0.9.0` [3].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.8.0
[2]: svengreb/tmpl-go#56
[3]: svengreb/tmpl-go#58

GH-91
svengreb added a commit to svengreb/wand that referenced this issue Apr 27, 2021
Updated to `tmpl-go` version `0.8.0` [1] which updated `golangci-lint`
to version `1.39.0` [2] and the `tmpl` repository version `0.9.0` [3].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.8.0
[2]: svengreb/tmpl-go#56
[3]: svengreb/tmpl-go#58

GH-91
svengreb added a commit to svengreb/wand that referenced this issue Apr 27, 2021
Updated to `tmpl-go` version `0.8.0` [1] which updated `golangci-lint`
to version `1.39.0` [2] and the `tmpl` repository version `0.9.0` [3].

[1]: https://github.com/svengreb/tmpl-go/releases/tag/v0.8.0
[2]: svengreb/tmpl-go#56
[3]: svengreb/tmpl-go#58

Closes GH-91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant