Fix DeepCopy result miss the _styles issue
#1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some svg element have styles which may includes `clip-path`, the `DeepCopy` method should handle the `_styles`
mzh3511
added a commit
to mzh3511/SVG
that referenced
this pull request
May 10, 2023
mrbean-bremen
approved these changes
May 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
May 10, 2023
…UTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt DeepCopy missed coping _styles BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Tests doc docfx.json index.md license.txt needed for svg elements with styles which include clip-path
H1Gdev
reviewed
May 10, 2023
| @@ -1044,6 +1044,10 @@ public virtual SvgElement DeepCopy<T>() where T : SvgElement, new() | |||
| foreach (var node in Nodes) | |||
| newObj.Nodes.Add(node.DeepCopy()); | |||
|
|
|||
| foreach (var style in _styles) | |||
| foreach (var pair in style.Value) | |||
H1Gdev
added a commit
to H1Gdev/SVG
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some svg elements have styles that may include
clip-path, theDeepCopymethod should handle the_styles