Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is xmlDeclaration working properly? #28

Closed
miguelmoraleda opened this issue Jan 4, 2015 · 2 comments
Closed

is xmlDeclaration working properly? #28

miguelmoraleda opened this issue Jan 4, 2015 · 2 comments
Assignees
Labels

Comments

@miguelmoraleda
Copy link

Hey @jkphl ,

I'm trying to set xmlDeclaration to false, but it is not working for me. Is this feature working properly?

My config looks like this:

svg_sprite: {
    your_target: {
        expand: true,
        cwd: '<%= config.src %>/assets/svg/',
        src: ['**/*.svg'],
        dest: '<%= config.dev %>/images/',
        options: {
            mode: {
                defs: {         // Activate the «view» mode
                    bust: false,
                    css: true,
                    dest: ''
                }
            },
            transform: [
                {svgo: {
                    plugins: [
                        { removeViewBox: false }, 
                        { removeUselessStrokeAndFill: false }, 
                        { cleanupIDs: false }, 
                        { mergePaths: false }
                    ]
                }}
            ],
            svg: {
                namespaceIDs: false,
                xmlDeclaration: false
            }
        }
    }
}

Thanks in advance.

Best regards,

Miguel

@jkphl
Copy link
Collaborator

jkphl commented Jan 4, 2015

Hey @miguelmoraleda,

you were right, thanks for that. Release v1.0.7 fixes this and improves XML & DOCTYPE declaration handling in general. Please let me know if you've still got problems.

Cheers,
Joschi

@jkphl jkphl closed this as completed Jan 4, 2015
@jkphl jkphl added the bug label Jan 4, 2015
@jkphl jkphl self-assigned this Jan 4, 2015
@miguelmoraleda
Copy link
Author

Hey @jkphl,

Thank you!! It is working properly 👍

Best regards,

Miguel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants