-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still maintained? #1055
Comments
@rugk Your link points to DuckDuckGo... |
Uuups… fixed, here is the correct one: https://fedoramagazine.org/design-faster-web-pages-part-2-image-replacement/ |
Well, I'd say this claim is correct. I'm doing some things (mostly bugfixing) from time to time, but have a little time to develop. |
Invite some new maintainers/collaborators on board? Seems plenty of people are keen to contribute. |
Not many people are really interested in it, unfortunately. |
⭐️ 10,000+ stars on GitHub, surely there is. |
@GreLI, you could start by putting someone else in charge of a new semi-official repository just for plugins, then you would only have to maintain the core plugins and the API. This would speed up development of new plugins while keeping the core code safe. You can merge the most popular plugins into the core once the bus have been ironed out in the other repo. |
Plugins is the least of problems. A major rewriting is needed to get significant improvement and to fix some issues. |
@GreLI, could you link to the relevant issues in the tracker, or maybe label them as "priority", or apply a milestone, or something like that? It would be good to have some idea what needs doing. |
It's just ideas, not really specified. Some pieces of them can be seen here or there. Some quick thaughts:
|
Also, could be cool if core automatically apply every action to check whether it efficient or should be reverted. |
@GreLI, the tool you have created is already very good (the best one I know of, in fact) so don't go tearing everything up and starting from scratch!
You already said you don't have time to properly maintain it as it is, so maybe your priority should be to implement features that reduce your workload, not increase it 😉 If you simply allowed plugins to be loaded from outside the project folder that would at least allow plugin to development to continue without requiring input from you, which would leave you free to work on the API. Might you consider giving somebody else commit access to the main repository? Or you could give the person access to a side repository for plugins, or something like that. (I'm also too busy to get involved, in case you were wondering, but I might be able to help you find somebody who would be interested.) If you are truly unable to carry on then you need to put some kind of notice in the README and GitHub project description because it's not fair to let people carry on submitting issues and PRs that go unnoticed. |
@shoogle: Using jsdom would probably also get rid of many redundancies like the code introduced by the inlineStyles plugin. There should be an object tree by jsdom or at least some library that can run on top of it. |
@GreLI could we start with the following:
|
@GreLI it'd be great to have a definitive answer, either:
@strarsis, @shoogle, @justrhysism would you be interested on collaborating as maintainers? |
@sk-: Yes, I use svgo extensively and contribute from time to time. IMHO I learned enough to be a co-maintainer. |
PR for replacing sax with saxes: #1281 |
I developed a library, alumna/unitflow, to solve situations exactly like GreLi's item # 2. It's possible to specify an execution sequence for svgo plugins (a "flow") and, if parallelism is desired, through separated flows it's possible to define dependencies between desired plugins on different flows, that will be fully respected in a non-blocking, reactive and asynchronous manner. Uniflow is made in pure JS, it has 0 dependencies and only 1.3kB, it's 100% tested and it's available both in CommonJS and ESM formats. |
It's also possible to define multiple flows programmatically with different combinations of plugins sequence, and check which one provides the best results. |
@paulocoghi: That's great, something between native JS and webpack. |
@strarsis yes, it can be used this way! Like gulp, but much simpler :) |
SVGO project is currently looking for new maintainer(s), please see #1320 |
Fedora Magazine claims this tool is not actively developed anymore?
IMHO this does not look like that. Could you clarify this?
The text was updated successfully, but these errors were encountered: