Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix excessive defs tag #1201

Merged
merged 2 commits into from
Feb 19, 2021
Merged

fix excessive defs tag #1201

merged 2 commits into from
Feb 19, 2021

Conversation

ChrisRu
Copy link
Contributor

@ChrisRu ChrisRu commented Dec 14, 2019

Fixes #1186

By checking whether there are any defs before making an element, it doesn't create an empty <defs/> element.

@ChrisRu
Copy link
Contributor Author

ChrisRu commented Dec 14, 2019

Test failure seems unrelated?

@jodaka
Copy link

jodaka commented May 27, 2020

would love to see this merged

@WORMSS
Copy link

WORMSS commented Aug 27, 2020

Is there any particular reason this PR is blocked for 8 months?

@ChrisRu
Copy link
Contributor Author

ChrisRu commented Aug 28, 2020

@WORMSS Seems like this project isn't very actively being maintained anymore (see #1055)

@XhmikosR
Copy link
Contributor

Can you rebase and add a test case please? Maybe then @TrySound could take care of merging this

@TrySound TrySound mentioned this pull request Feb 19, 2021
@ChrisRu
Copy link
Contributor Author

ChrisRu commented Feb 19, 2021

Rebased and added a 'regression test'. Let me know if you need anything else

@TrySound TrySound merged commit b988049 into svg:master Feb 19, 2021
@TrySound
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty defs added
5 participants